Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several patches for Sanctuary Fortress - Minigyro Chamber #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

UltiNaruto
Copy link
Contributor

@UltiNaruto UltiNaruto commented Jul 4, 2023

Added Cannon Ball fix for Sanctuary Fortress - Minigyro Chamber

Modify the triggers to force push the morph ball in a direction instead of using the knockback of damage trigger

Added no backward traversal QoL patch for Sanctuary Fortress - Minigyro Chamber

Add a trigger at the back of the gyroscope that sends you away from the gyroscope to prevent backward traversal

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Attention: Patch coverage is 16.66667% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 81.97%. Comparing base (513b20f) to head (6114382).

Files Patch % Lines
...c/open_prime_rando/echoes/specific_area_patches.py 16.66% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   83.25%   81.97%   -1.28%     
==========================================
  Files          38       38              
  Lines        1547     1576      +29     
==========================================
+ Hits         1288     1292       +4     
- Misses        259      284      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@duncathan duncathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're gonna need to wait until #58 is merged and then fix your conflicts before we can really review this

Added Cannon Ball fix for Sanctuary Fortress - Minigyro Chamber
Added no backward traversal QoL patch for Sanctuary Fortress - Minigyro Chamber
@UltiNaruto
Copy link
Contributor Author

Rebased to latest commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants